Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SHARED from pybind11_add_module #1305

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

Remove SHARED from pybind11_add_module #1305

wants to merge 1 commit into from

Commits on Jun 20, 2024

  1. Remove SHARED 

    When the module is compiled with `MODULE` (the default), the proper linker flags are added on macOS (specifically `-undefined dynamic_lookup`). Otherwise, `rclpy` segfaults when linked on conda. 

Is the `SHARED` really necessary? The `pybind11` documentation says:

> Specifying `SHARED` will create a more traditional dynamic library which can also be linked from elsewhere. 

Is anyone linking against this library as a "traditional dynamic library"?

Signed-off-by: Wolf Vollprecht <w.vollprecht@gmail.com>
    @wolfv
    wolfv authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    732be7e View commit details
    Browse the repository at this point in the history