Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement functions to get publisher and subcription informations like QoS policies from topic name #960

Merged
merged 13 commits into from
Feb 14, 2020
Merged

Implement functions to get publisher and subcription informations like QoS policies from topic name #960

merged 13 commits into from
Feb 14, 2020
+530 −1

Commits on Feb 7, 2020

  1. get publisher and subscription information from topic name 

    Signed-off-by: Barry Xu <Barry.Xu@sony.com>
    @Barry-Xu-2018 @mm318
    Barry-Xu-2018 authored and mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    72ffd44 View commit details
    Browse the repository at this point in the history

  2. Update with comments and fix some changes of rmw 

    Signed-off-by: Barry Xu <Barry.Xu@sony.com>
    @Barry-Xu-2018 @mm318
    Barry-Xu-2018 authored and mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    b2e1d03 View commit details
    Browse the repository at this point in the history

  3. update templated get_info_by_topic() function 

    Signed-off-by: Barry Xu <Barry.Xu@sony.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    142e32a View commit details
    Browse the repository at this point in the history

  4. address some of the PR comments 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    c9ff531 View commit details
    Browse the repository at this point in the history

  5. change rclcpp::EndpointType to an enum class 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    a79f8e4 View commit details
    Browse the repository at this point in the history

  6. fix punctuation in docstring 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    4db2a31 View commit details
    Browse the repository at this point in the history

  7. address more PR comments 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    67ca5b8 View commit details
    Browse the repository at this point in the history

  8. add get_publishers/subscriptions_info_by_topic() to LifecycleNode 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    88af887 View commit details
    Browse the repository at this point in the history

  9. remove weird punctuation from docstring 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    814117c View commit details
    Browse the repository at this point in the history

  10. add topic name remapping to get_info_by_topic() 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    634d588 View commit details
    Browse the repository at this point in the history

  11. remove useless line of code 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    bc1b891 View commit details
    Browse the repository at this point in the history

  12. remove non-applicable comment 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 7, 2020
    Configuration menu
    Copy the full SHA
    9911d24 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. make members of TopicEndpointInfo private 

    Signed-off-by: Miaofei <miaofei@amazon.com>
    @mm318
    mm318 committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    cb064f2 View commit details
    Browse the repository at this point in the history