Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix busy loop in spin_node_until_future_complete() #70

Merged
merged 1 commit into from
Jul 29, 2015

Conversation

dirk-thomas
Copy link
Member

No description provided.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 29, 2015
@dirk-thomas dirk-thomas self-assigned this Jul 29, 2015
@esteve
Copy link
Member

esteve commented Jul 29, 2015

+1

1 similar comment
@wjwwood
Copy link
Member

wjwwood commented Jul 29, 2015

+1

dirk-thomas added a commit that referenced this pull request Jul 29, 2015
fix busy loop in spin_node_until_future_complete()
@dirk-thomas dirk-thomas merged commit 38bbcda into master Jul 29, 2015
@dirk-thomas dirk-thomas deleted the fix_busy_loop branch July 29, 2015 19:18
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jul 29, 2015
mauropasse pushed a commit to mauropasse/rclcpp that referenced this pull request Jun 21, 2021
rename lock free queue and remove wait_for_event API
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* ros2GH-69 Read storage content in a separate thread

For now the publishing starts only after the reading is completly
done. This should change aufter ros2GH-68 is done and a thread-safe
queue can be used instead of std::queue.

* ros2GH-71 Add integration test for timing behavior

* ros2GH-68 Introduce vendor package for shared queue

- Download and install headers from moodycamel readerwriterqueue
- Download and install headers from moodycamel concurrentqueue
- Use readerwriterqueue in code to load and publish concurrently

* ros2GH-71 Retain time difference of messages when playing a bag file

- The main (play) thread sleeps until the time for publishing the
  message is reached.
- Using std::chrono time_point and duration for type-safe time
  arithmetic instead of rcutils time types.

* ros2GH-71 Improve stability of read test

- Subscribers need to maintain a longer history if the messages are
  not consumed fast enough.

* ros2GH-71 Fix Classloader instance lifetime

The Classloader instance needs to outlive all objects created by it.

* ros2GH-71 Extract playing code into a class of its own

Reason: record and play have almost no common code but do the exact
opposite with the storage and rclcpp.

* ros2GH-70 Do not link explicitly against std_msgs

- only required in tests
- this decreases the amount of packages needed for a clean build without tests

* ros2GH-70 Fix error message of storage

* ros2GH-70 Fix pluginlib/storage issue for recording

* ros2GH-71 Cleanup: variable naming

* ros2GH-70 Load storage continuously instead of as fast as possible

- Only load if queue contains less than 1000 messages
- Wait a millisecond before loading again once the queue is long enough

* ros2GH-70 Add options struct to allow specification of queue size

* ros2GH-72 Wait for messages to fill up

* ros2GH-74 Rename integration tests to play/record tests

* ros2GH-74 Use test_msgs in integration tests

- gets rid of string_msgs dependency

* ros2GH-70 Rename is_not_ready to is_pending, use bulk reading to queue

* ros2GH-70 Harmonize storage_loading_future variable

* ros2GH-88 Read messages in order of their timestamps

- Currently, we write sequentially in order of arrival time so
  reading in id order is fine
- This may change at a later time and should not change the reading
  behaviour, i.e. we need to read in order of timestamps

* Fix compiler error on Mac

* ros2GH-8 Fix: use correct ros message type in test

* ros2GH-8 Cleanup: minor code style fixes

* ros2GH-8 Refactor future usage in player

Make the future a class member of player to avoid having to hand it
into several functions which is difficult with a move-only type.

* ros2GH-8 Cleanup: remove verbose logging for every stored message

* ros2GH-8 Refactor rosbag2 interface

Add an explicit overload for record without a topic_names argument to
record all topics.

* fix: call vector.reserve instead of default initalization

* fix record demo
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
* ros2GH-134 Split converter interface into Serializer and Deserializer

- Allow plugins which can only read or write
- Most important example: plugin for old rosbags

* ros2GH-134 Switch to using serializer and deserializer in factory

* ros2GH-134 Add test for serializer plugin

* ros2GH-134 Try to load Serializer and Deserializer

- When loading a serializer, try to load both serializer and converter
- Similar for deserializers

* ros2GH-134 Fix e2e test after improving error message for missing converters

* ros2GH-134 Remove duplicate code in converter factory

* ros2GH-134 Change namespace of converter interfaces

- adapt namespaces to folder structure
- folder structure similar to rosbag2_storage

* ros2GH-134 Hide pluginlib import via pimpl

- We want to use template functions that require the pluginlib import
- The pluginlib import should not be exported (this creates issues with
  downstream packages)
- Similar to the storage factory, use a pimpl

* ros2GH-134 Adapt documentation

* Minor documentation updates

Co-Authored-By: Martin-Idel-SI <external.Martin.Idel@bosch-si.com>

* ros2GH-134 Rename converter interface to drop "interface"

- already visible from namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants