-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
construct TimerBase/GenericTimer with Clock #523
Conversation
77796df
to
2e41fb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks alright to me, just some docs I noticed would be out-of-date.
@@ -112,8 +112,10 @@ class GenericTimer : public TimerBase | |||
* \param[in] period The interval at which the timer fires. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing parameter doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 0462196.
rclcpp/include/rclcpp/timer.hpp
Outdated
@@ -95,11 +97,9 @@ using TimerCallbackType = std::function<void (TimerBase &)>; | |||
/// Generic timer templated on the clock type. Periodically executes a user-specified callback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc needs update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 0462196.
Absolutely, packages on-top of |
It would be nice to have a |
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
* Add record test for ros2bag A nominal smoke test to confirm that the tool is working. Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove unused import Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix lint Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Expect exit code 2 from rclcpp Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Remove unused import Signed-off-by: Jacob Perron <jacob@openrobotics.org> * Fix test for Windows Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Extend the Timer API to take a Clock.
Requires ros2/rcl#272.