Fix for memory leaks in the rclcpp::SerializedMessage #2861
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @kylemarcey |
Signed-off-by: Michael Orlov <morlovmr@gmail.com> Co-authored-by: kylemarcey <marcey.kyle@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/fix-memory-leaks-in-serialized-message
branch
from
adffd3c to
1e5cd9c
Compare
fujitatomoya
approved these changes
May 28, 2025
|
lgtm. Did these leaks have any real effect in nominal usage or would they only occur under 'weird' usage ? |
jmachowinski
approved these changes
May 28, 2025
ahcorde
approved these changes
May 28, 2025
|
Pulls: #2861
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes memory leaks found in the
rclcpp::SerializedMessagecopy assignment operatorsFixes # (issue) N/A
Is this user-facing behavior change?
No
Did you use Generative AI?
No.
Additional Information
These memory leaks were found with memory sanitizer.