Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Unified Node Interface (NodeInterfaces class) #2041

Merged
merged 17 commits into from
Dec 29, 2022
Merged

Implement Unified Node Interface (NodeInterfaces class) #2041

merged 17 commits into from
Dec 29, 2022

Commits on Dec 28, 2022

  1. Implement NodeHandle 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    28b7fe0 View commit details
    Browse the repository at this point in the history

  2. Fix comment typo 

    Signed-off-by: methylDragon <methylDragon@gmail.com>

Co-authored-by: William Woodall <william+github@osrfoundation.org>
    @methylDragon @wjwwood
    methylDragon and wjwwood committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    5abd538 View commit details
    Browse the repository at this point in the history

  3. Use NodeInterfaceHandle as class name instead 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    683b34e View commit details
    Browse the repository at this point in the history

  4. Remove interface aliases 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    a612f01 View commit details
    Browse the repository at this point in the history

  5. Move implementation to node_interfaces 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    afb780b View commit details
    Browse the repository at this point in the history

  6. Use multiple inheritance in NodeInterfaceHandle 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    912898f View commit details
    Browse the repository at this point in the history

  7. Fix tests and linters 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    5fb2f95 View commit details
    Browse the repository at this point in the history

  8. Rename to NodeInterfaces and make constructor implicit 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    31bbe74 View commit details
    Browse the repository at this point in the history

  9. Update docs 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    44f3b20 View commit details
    Browse the repository at this point in the history

  10. Implement shared_ptr constructors and refine const 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    ba7a159 View commit details
    Browse the repository at this point in the history

  11. Implement non-mutable NodeInterfaces 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    7dabad9 View commit details
    Browse the repository at this point in the history

  12. refactor to use a std::tuple and be immutable (#1) 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: methylDragon <methylDragon@gmail.com>
    @wjwwood @methylDragon
    wjwwood and methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    8657fd1 View commit details
    Browse the repository at this point in the history

  13. Update tests, add docstrings, and update lifecycle nodes 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    0257c79 View commit details
    Browse the repository at this point in the history

  14. Update tests 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    ce29db1 View commit details
    Browse the repository at this point in the history

  15. Attempt to fix template fold expression 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    c688476 View commit details
    Browse the repository at this point in the history

  16. Refine package 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    cf31bb8 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2022

  1. Implement ALL_RCLCPP_NODE_INTERFACES 

    Signed-off-by: methylDragon <methylDragon@gmail.com>
Co-authored-by: methylDragon <methylDragon@gmail.com>
    @methylDragon
    methylDragon committed Dec 29, 2022
    Configuration menu
    Copy the full SHA
    fa69bf1 View commit details
    Browse the repository at this point in the history