Skip to content

Commit

Permalink
fix: Fixed race condition in action server between is_ready and take"… (
Browse files Browse the repository at this point in the history
#2531)

* fix: Fixed race condition in action server between is_ready and take" (#2495)

Some background information: is_ready, take_data and execute data
may be called from different threads in any order. The code in the old
state expected them to be called in series, without interruption.
This lead to multiple race conditions, as the state of the pimpl objects
was altered by the three functions in a non thread safe way.

Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

* fix: added workaround for call to double calls to take_data

This adds a workaround for a known bug in the executor in iron.

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>

---------

Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Co-authored-by: Janosch Machowinski <J.Machowinski@cellumation.com>
Co-authored-by: William Woodall <william@osrfoundation.org>
  • Loading branch information
3 people authored Jun 27, 2024
1 parent c1a01fc commit d588ccb
Show file tree
Hide file tree
Showing 2 changed files with 444 additions and 240 deletions.
Loading

0 comments on commit d588ccb

Please sign in to comment.