Remove rcl_logging_log4cxx. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't ever use it, and having it around causes a few problems: 1. We have an unnecessary, and unneeded dependency on log4cxx in the core. 2. We can't currently build against libc++ with log4cxx. 3. Log4cxx causes some absolute paths to be in the delivered packages on Windows. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Full CI:
|
|
The other good thing about doing this is that we'll be able to get rid of the log4cxx dependency. Before I go ahead with this, any objections @cottsay or @nuclearsandwich ? |
|
Even though the full CI was a month ago, nothing substantial has changed here. So I'm just going to rely on that and the approval from @ivanpauno, and go ahead and merge this. There is probably some follow-up work in the documentation and the CI jobs that needs to be done, which I'll look at next. |
clalancette
added a commit
to clalancette/ros2_documentation
that referenced
this pull request
Sep 14, 2021
It is no longer required as of ros2/rcl_logging#78 Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added a commit
to ros2/ros2_documentation
that referenced
this pull request
Sep 14, 2021
It is no longer required as of ros2/rcl_logging#78 Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't ever use it, and having it around causes a few problems:
core.
on Windows.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
@ivanpauno FYI, this should get rid of one more of the problems pointed out in ros2/rclcpp#1688