Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update test fixtures for char type #64

Merged
merged 2 commits into from
Mar 12, 2019
Merged

update test fixtures for char type #64

merged 2 commits into from
Mar 12, 2019

Conversation

dirk-thomas
Copy link
Member

Connected to ros2/rosidl#334.

@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Feb 15, 2019
@dirk-thomas dirk-thomas self-assigned this Feb 15, 2019
@dirk-thomas dirk-thomas mentioned this pull request Feb 15, 2019
Closed
8 tasks
@dirk-thomas dirk-thomas force-pushed the idl-stage-7 branch 2 times, most recently from 18c3ad7 to 9811461 Compare February 19, 2019 19:53
@dirk-thomas dirk-thomas changed the title update test fixture for char type update test fixtures for char type Feb 19, 2019
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
hidmic
hidmic reviewed Feb 23, 2019
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though many of the test values have changed e.g. 0x7F != 255, 0x11 != 11, etc. But I can't seem to find anything relying on them so I think we're fine.

@dirk-thomas
Copy link
Member Author

though many of the test values have changed

Just because the type and valid value range has changed.

@hidmic
Copy link
Contributor

hidmic commented Feb 25, 2019

Looks like I don't have true powers here :(

@dirk-thomas dirk-thomas merged commit caa603d into master Mar 12, 2019
@dirk-thomas dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:12
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirk-thomas @hidmic