Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mem leaks in unit test from 776 #779

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Fix mem leaks in unit test from 776 #779

merged 1 commit into from
Aug 31, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Aug 31, 2020

PR #776 removed the the call to rcl_yaml_node_struct_fini from rcl_parse_yaml_file in the case of failure. Unfortunately the unit tests weren't updated and now exhibit some memory leaks. This PR addresses those leaks.
Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Fix mem leaks in unit test from 776
5757ff5 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested a review from hidmic August 31, 2020 22:37
@brawner brawner mentioned this pull request Aug 31, 2020
Merged
@brawner
Copy link
Contributor Author

brawner commented Aug 31, 2020

Tests --packages-select rcl_yaml_param_parser

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner
Copy link
Contributor Author

brawner commented Aug 31, 2020

With this PR both test_parser.cpp and test_parse_yaml.cpp run without any memory leaks.

hidmic
hidmic approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@hidmic hidmic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for the fix @brawner !

@brawner brawner merged commit 6040298 into master Aug 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/rcl_yaml-mem-leaks-776 branch August 31, 2020 23:03
@hidmic hidmic mentioned this pull request Sep 2, 2020
Merged
ahcorde pushed a commit that referenced this pull request Oct 8, 2020
@brawner @ahcorde
Fix mem leaks in unit test from 776 (#779)
8375031 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
@brawner @ahcorde
Fix mem leaks in unit test from 776 (#779)
a34c481 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brawner @hidmic