Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rcl_parse_yaml_file() error handling. #776

Merged
merged 3 commits into from
Aug 31, 2020
Merged

Fix rcl_parse_yaml_file() error handling. #776

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
250f934
Fix rcl_parse_yaml_file() error handling.
hidmic Aug 31, 2020
1ebb39a
Clarify rcl_parse_yaml_file() documentation.
hidmic Aug 31, 2020
be78d0d
Fix silly spelling error.
hidmic Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions rcl_yaml_param_parser/src/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,12 +1810,7 @@ bool rcl_parse_yaml_file(
allocator.deallocate(ns_tracker.parameter_ns, allocator.state);
}

if (RCUTILS_RET_OK != ret) {
rcl_yaml_node_struct_fini(params_st);
return false;
}

return true;
return RCUTILS_RET_OK == ret;
}

///
Expand Down