Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against returning NULL or empty node names #570

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Guard against returning NULL or empty node names #570

merged 6 commits into from
Mar 26, 2021

Commits on Mar 25, 2021

  1. Guard against returning NULL or empty node names 

    Return an error instead.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d6b6e34 View commit details
    Browse the repository at this point in the history

  2. Update documentation 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    4a082af View commit details
    Browse the repository at this point in the history

  3. Separate error messages for null vs empty 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f4858fc View commit details
    Browse the repository at this point in the history

  4. Guard against null namespaces 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    5ae5e40 View commit details
    Browse the repository at this point in the history

  5. Fix variable name 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    42061bb View commit details
    Browse the repository at this point in the history

  6. Use more specific error codes 

    Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    8db9fac View commit details
    Browse the repository at this point in the history