Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename action state transitions #409

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Conversation

jacobperron
Copy link
Member

Now using active verbs.
Resolves #399.

@jacobperron jacobperron added the in progress Actively being worked on (Kanban column) label Mar 30, 2019
@jacobperron
Copy link
Member Author

...I just released that there are now two events named GOAL_EVENT_CANCEL. Rethinking the change.

Now using active verbs.
Resolves #399.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Apr 1, 2019
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

Updated based on design discussion (ros2/design#226). @hidmic, please take another look.

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobperron jacobperron merged commit 26744b0 into master Apr 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/rename_action_events branch April 16, 2019 11:46
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename action state transitions
2 participants