Yaml param parser shane review 2 - #241
Merged
Merged
Conversation
mikaelarguedas
approved these changes
May 25, 2018
mikaelarguedas
left a comment
mikaelarguedas
left a comment
Member
There was a problem hiding this comment.
LGTM, That's the branch I'v been using for testing on windows 👍.
Just checking: Did you run CI with that branch on the other platforms ?
Contributor
Author
|
@mikaelarguedas I have not. I know it at least works in my xenial docker container locally, but have not tested OSX or the arm job. |
Member
|
Can you please run a MacOS job? (linux is not necessary if it works on your machine) |
Contributor
Author
|
@mikaelarguedas OSX with this branch and |
Member
|
Thanks 👍 |
Contributor
|
Looks good. Will go ahead and merge it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple changes for windows:
1: Remove include
uinistd.h2: Use size_t for array indexes to eliminate warnings about possible loss of data