-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BatteryState.msg #206
Conversation
Add ternary lithium battery to power_supply_technology. Signed-off-by: Borong Yuan <yuanborong@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really familiar with battery chemistries in general, and ternary in particular. Can you provide some links that talk about it?
Lithium iron phosphate battery and ternary lithium battery are the two most common types of power batteries in AGV/AMR and electric vehicles. If not subdivided, they can all be counted as lithium polymer batteries (POWER_SUPPLY_TECHNOLOGY_LIPO). When I was working on a driver for a BMS recently, I found that it supports both battery types with slightly different handling. I think it can be handled a bit more explicitly in sensor_msgs, although it may not be of much use at the moment. It might be useful for later more advanced features, such as battery modeling in RMF. P.S. POWER_SUPPLY_TECHNOLOGY_LIFE stands for LiFePO4 right? So we don't have to add another item for it. |
@borongyuan Can you please add a short version of that explanation to the interface definition as a comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this looks good, with some more documentation in the comments for clarity.
Add Valve Regulated Lead-Acid battery and definition of constants Signed-off-by: Borong Yuan <yuanborong@hotmail.com>
I have added definition for constants. Hope my understanding of the original contributor(@tfoote )'s definition is correct. I also added lead acid battery. Although this is an older, even somewhat outdated technology, it is still widely used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me; thanks for adding the extra comments!
Thanks for the contribution! |
Add ternary lithium battery to power_supply_technology.