Skip to content

update CI with jazzy and noble #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

knmcguire
Copy link
Contributor

@knmcguire knmcguire commented Jun 16, 2025

An update to the CI

  • Adding Jazzy Jalisco
  • Changing Rolling tooling to Ubuntu 24.04 noble (so latest)

Do we want to keep supporting humble? and how about short term releases as iron and kilted

Update: I still have to update the minimal build and see if everything goes through error free, hence the that this PR is still on draft. Also there is #489 that will fix the windows build

@jhdcs
Copy link
Collaborator

jhdcs commented Jun 16, 2025

Considering we're trying to have this client library be a Tier 1, I think we should support Humble (and other versions) for as long as ROS 2 supports them. So if a version becomes EOL, our support becomes EOL.

I am open to being overruled by the other maintainers if they feel that would be an unrealistic ask, though.

@knmcguire
Copy link
Contributor Author

Alright. In that sense I can also add Kilted. Iron is of course already EOL.

Once the PR is ready to be reviewed I'll share it on Matrix

@knmcguire
Copy link
Contributor Author

I've removed Kilted again since it is not yet available in rostooling it seems: https://github.com/ros-tooling/setup-ros-docker

I'll start a issue/pr over there, but for now I've commented it out here

Copy link
Collaborator

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look upstream and it seems kilted is now available, can you uncomment it?

@knmcguire
Copy link
Contributor Author

Absolutely :) the rostooling peeps were really quick to respond after opening my ticket for kilted there! PR merged in record time!

@knmcguire
Copy link
Contributor Author

knmcguire commented Jun 17, 2025

ah no it's too fresh. We need to wait for the new action-ros-ci (and setup-ros?) to be released with kilted. It's either that or always be on the @main version of those but don't think we should do that to keep the CI stable.

So, shall we wait for that for this PR or shall I remove Kilted again such that we can do another PR once the tooling has been released @luca-della-vedova ?

@luca-della-vedova
Copy link
Collaborator

ah no it's too fresh. We need to wait for the new action-ros-ci (and setup-ros?) to be released with kilted. It's either that or always be on the @main version of those but don't think we should do that to keep the CI stable.

So, shall we wait for that for this PR or shall I remove Kilted again such that we can do another PR once the tooling has been released @luca-della-vedova ?

It seems both have kilted support, setup-ros on a new 0.7 version (so it should be picked up automatically), action-ros-ci on 0.4.3 so if we bump to 0.4 it should be picked up

Copy link
Collaborator

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment for curiosity but this looks great, thank you! This (especially jazzy) is very overdue

Comment on lines +70 to +74
# Colcon can not be run in a venv which is required in Ubuntu Noble
# Removing the externally managed file
- name: Install colcon-cargo and colcon-ros-cargo
run: |
sudo rm -f /usr/lib/python3.12/EXTERNALLY-MANAGED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting, I guess this is an alternative to the --break-system-packages flag? I didn't know this could be done!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes I read about that flag too. But I got this idea from my co-maintainer at Crazyswarm2 (see this line). But seems to work out!

@knmcguire knmcguire marked this pull request as ready for review June 17, 2025 14:40
@knmcguire
Copy link
Contributor Author

Everything is building so feel free to merge if it's all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants