Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for
rclrs
supporting actions (#410), it will need new dependencies on certain interface packages: specifically,action_msgs
and its dependencyunique_identifier_msgs
. Sincerclrs
is a crate on crates.io and the interface packages are not, they need to be vendored into therclrs
code. This PR does so.In the first commit, the
rclrs/vendor_interfaces.py
script is updated to vendor the above message packages in addition to the existing ones. In the process, the set of vendored packages is collapsed into a single list rather than being repeated throughout the script. Support is also added for packages with anaction.rs
file, though this is not currently used.The second commit silences the
clippy::derive_partial_eq_without_eq
andclippy::upper_case_acronyms
lints in the generated code for interface packages. This was already being done by the vendored packages inrclrs
, but was moved torosidl_generator_rs
for the sake of downstream users who may also enforceclippy
on them.The third commit is the result of running the updated script on the
install
output of the desired packages with the latest version of therosidl_generator_rs
generator. In addition to introducing the new vendored packages, this resulted in some trivial changes to the existing ones: replacingstd::os::raw::c_void
with its aliasstd::ffi::c_void
and a whitespace change.