Skip to content

Refactoring Of Dependency usage #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 93 commits into from
Closed

Refactoring Of Dependency usage #387

wants to merge 93 commits into from

Conversation

@Guelakais
Copy link
Contributor

@Guelakais Guelakais commented Apr 5, 2024

I just tidied up the imports a little. I have also built and tested everything with the changes. No problems.

GueLaKais added 27 commits April 4, 2024 23:43
Refactoring of Dependency usage
485750a
Refactoring of Dependency usage
2f88ce0
Refactoring of Dependency usage
374e44d
Refactoring of Dependency usage
77443ae
Refactoring of Dependency usage
19948ef
Refactoring of Dependency usage
cbe8e0f
Refactoring of Dependency usage
f373cae
Refactoring of Dependency usage
2735b04
Refactoring of Dependency usage
ab43784
Refactoring of Dependency usage
a8f98eb
Refactoring of Dependency usage
686c4e7
Refactoring of Dependency usage
c2ec39c
Refactoring of Dependency usage
e5ff1db
Refactoring of Dependency usage
f7a22f6
Dependency import refactoring
ebb728c
Dependency import refactoring
2a564fe
Dependency import refactoring
9decfe6
Dependency import refactoring
9262303
Dependency import refactoring
38fdff5
Dependency import refactoring
7d31d24
Dependency import refactoring
6e92e64
Dependency import refactoring
2fbf21c
Dependency import refactoring
b08a954
Dependency import refactoring
28d91ce
Dependency import refactoring\
1902657
Dependency import refactoring\
3771a52
Dependency import refactoring\
d245519
@mxgrey
Copy link
Collaborator

mxgrey commented Apr 5, 2024

I personally prefer the style that you've migrated to in this PR, but I think this kind of change needs to be discussed in the working group before moving forward. I'll bring this up at the next meeting which is this coming Monday.

If the working group approves of this style, then I think this PR should be updated to add a .rustfmt.toml file to the root directory with a imports_granularity = Crate setting. That way this style will be enforced by the CI and we won't have to periodically clean up style entropy down the road.

GueLaKais added 27 commits April 9, 2024 10:18
Autoformating the file
908b1b5 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
dae5de7 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
6482f51 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
d704faa 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
b8e41b5 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
3366a7b 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
d3771b6 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
4a9078a 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
68de895 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
e97f061 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
f625f75 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
3d2d053 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
b98d928 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
00c7bf7 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
c82e450 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
457fb7a 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
ebff7da 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
2460021 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
45fb400 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
b208002 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
90dafb0 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
cd12430 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
375807f 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
cd91b61 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
ceeb36a 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Autoformating the file
9effcf6 
* Action: Applied code formatting
* Details:
  * Used cargo fmt to format Rust source code.
  * Introduced a .rustfmt.toml file to configure and enforce consistent
formatting on future changes.
Merge branch 'refactoring' of github.com:Guelakais/ros2_rust into ref…
2f84d63 
…actoring
@Guelakais Guelakais closed this Apr 9, 2024
@Guelakais Guelakais deleted the refactoring branch April 9, 2024 09:43
@Guelakais Guelakais mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Guelakais @mxgrey