Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WaitSet::new_for_node() #276

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Add WaitSet::new_for_node() #276

merged 1 commit into from
Oct 5, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Oct 4, 2022

This function is important for users who directly use wait sets, since the Node::live_subscriptions() etc. functions are not public.

This function is important for users who directly use wait sets, since the live_subscriptions() etc. functions are not public.
@nnmm nnmm requested a review from a team October 5, 2022 09:56
Copy link
Collaborator

@jhdcs jhdcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough. I'm assuming that there are some functions coming down the pipe that will make use of this?

@nnmm
Copy link
Contributor Author

nnmm commented Oct 5, 2022

Thanks! Not really, I just noticed that this function was needed while working on something that probably won't land in ros2-rust.

@nnmm nnmm merged commit 4956c31 into main Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the new_wait_set_for_node branch October 5, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants