Skip to content

Ensure that a waitable is only added to one wait set at a time #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2022
Merged

Ensure that a waitable is only added to one wait set at a time #224

merged 4 commits into from
Jul 15, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Jul 11, 2022 •
edited
Loading

Closes #207.

The use of atomic bools follows rclcpp's approach.

@nnmm nnmm changed the base branch from main to remove_subscription_handle July 11, 2022 09:32
@nnmm nnmm requested a review from a team July 11, 2022 09:35
@nnmm nnmm mentioned this pull request Jul 13, 2022
Closed
@nnmm nnmm force-pushed the add_already_in_use_bool branch from 346f38f to a386f64 Compare July 13, 2022 12:27
@nnmm nnmm changed the base branch from remove_subscription_handle to main July 13, 2022 12:27
esteve
esteve reviewed Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnmm looks good overall. Could you add a unit test for ExclusivityGuard and perhaps another for when a Subscription/Client/Service is added to a WaitSet twice and to two different WaitSets? Thanks.

@nnmm nnmm force-pushed the add_already_in_use_bool branch 2 times, most recently from 8cbe025 to 7aab7c2 Compare July 15, 2022 06:42
@nnmm nnmm force-pushed the add_already_in_use_bool branch from 7aab7c2 to 0bf7ddf Compare July 15, 2022 06:57
@esteve
Copy link
Collaborator

esteve commented Jul 15, 2022

@nnmm thanks!

@nnmm nnmm merged commit 32f942e into main Jul 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the add_already_in_use_bool branch July 15, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track all waitables that are currently in a wait set
2 participants
@nnmm @esteve