Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for actions #244

Open
nnmm opened this issue Jul 31, 2022 · 4 comments
Open

Add support for actions #244

nnmm opened this issue Jul 31, 2022 · 4 comments
Assignees

Comments

@nnmm
Copy link
Contributor

nnmm commented Jul 31, 2022

Actions are essentially pub/sub + clients/services, both of which are already implemented, so this should be relatively straightforward.

@Tacha-S
Copy link
Contributor

Tacha-S commented Oct 20, 2022

I'm adding action messages generator as a start to implementing the action server.
The service message struct is ServiceName_[Request/Responce], is this different from Rust naming rule to avoid conflicts with default service struct?
I think that the service request/response messages do not conflict with other messages, because service struct is in srv module and request/response messages in srv::rmw module.
I checked implementation PR, but can't find any discussion.
Do you know any another reasons?

@nnmm
Copy link
Contributor Author

nnmm commented Oct 20, 2022

@esteve Please see the question above.

@esteve esteve self-assigned this Feb 26, 2023
@esteve
Copy link
Collaborator

esteve commented Feb 26, 2023

@Tacha-S I hadn't received a notification for your comment, I'm terribly sorry for the slow response. Are you still interested in actions? I started the work in #295, which has a generator for action structures, but it's still missing the code for actually sending/processing actions. Would you be interested in contributing to it? Thanks.

@Tacha-S
Copy link
Contributor

Tacha-S commented Apr 9, 2023

I don't have much free time these days either, but I haven't lost interest, and I will submit a PR if I can make it to the point where I can contribute regarding sending/processing actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants