Add examples #6
Merged
Add examples #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add example launch Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp> * docs: fix README.md Co-authored-by: Nikolai Morin <nnmmgit@gmail.com> Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
* Move create_node and create_node_builder back to the rclrs module * Fix tests * Fix tests * Fix formatting
* Added support for clients and services
This was not a straightforward extension because 1. ReadOnlyLoanedMessage has a lifetime 2. The take_loaned_message() method was restricted to Subscription<T: RmwMessage>, i.e. not available for subscriptions on idiomatic messages. This has been fixed and now the method is implemented for Subscription<T: Message> like the other `take*` methods – though you still will get an RMW-native loaned message even if T is the idiomatic message type, because idiomatic message types can never be loaned.
…tions (#294) * Fine-grained locks. Made create_subscription, create_service, create_client not take a mutable self * Return an Arc from rclrs::create_node to match other create_X functions * Update spin* to take an Arc * Fix clippy warning
* Added rclcpp/rclpy-like executor * Fix comments
* Add check if service is ready * Update changelog * Fix unneeded return --------- Co-authored-by: carter <carterjschultz@gmail.com> Co-authored-by: carter <carter@amprobotics.com>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
This reverts commit e7065a7fb19d3d852bc9e978ac43cc4914750ca5.
* Add wchar support and .idl example * Undo automatic IDE formatting noise * Added back unused imports to see if this fixes the build * More attempts to fix the weird build failure * Removed the linter tests for auto-generated message source files in `rclrs_example_msgs`. Re-applied some changes removed when root causing. --------- Co-authored-by: Sam Privett <sam@privett.dev>
…ackage was only ever used by examples. (#384)
* Use nightly for style check Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Install nightly for cargo +nightly fmt Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix style in examples Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Update style for rosidl_runtime_rs Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Add a comment indicating that nightly release is needed for formatting Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> --------- Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
…ntation #378 (#390) * Added another tutorial to ros2 rust. --------- Co-authored-by: GueLaKais <koroyeldores@gmail.com> Co-authored-by: GueLaKais <koryeldiores@gmail.com> Co-authored-by: Esteve Fernandez <esteve@apache.org> Co-authored-by: Esteve Fernandez <33620+esteve@users.noreply.github.com> Co-authored-by: Sam Privett <privett.sam@gmail.com>
* Fix buffer overflow for bounded sequence example Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Allow longer characters for wstring Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
* Migrate Context, Executor, and Node creation to new API Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Update examples Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix documentation Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix formatting Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix example formatting Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Implicitly cast &str to NodeOptions Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Remove debug outputs Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix formatting Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Return a Vec of errors from spinning Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * update examples Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix example formatting Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Introduce CreateBasicExecutor trait Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix formatting Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Add documentation for Context::default Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Automatically clear dead nodes from the executor Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Update reference index Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix style Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
* Migrate to SubscriptionOptions Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Migrate to PublisherOptions Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Migrate to ServiceOptions Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Migrate to ClientOptions Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Enable direct creation of the _Options for all primitive types Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix example formatting Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix docs Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Make deadline, liveliness_lease, and lifespan all symmetric Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Add an API to the primitive options builder for avoiding ROS namespace conventions Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Retrigger CI Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix: Override all profile options when using .qos Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Reword the warning for system_qos Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Reword the warning for QoSProfile::system_default Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Rename PrimitiveOptions::apply to apply_to Signed-off-by: Michael X. Grey <greyxmike@gmail.com> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com> Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
* Migrate Node to shared state pattern Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Migrate primitives to state pattern Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix examples Signed-off-by: Michael X. Grey <greyxmike@gmail.com> * Fix merge errors Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix style Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix doc Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com> Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Esteve Fernandez <esteve@apache.org>
* Squash async worker changes Signed-off-by: Michael X. Grey <greyxmike@gmail.com> Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix bug in logging macros Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Clean up examples using new API Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Ensure workers wake up when a task is run Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Iterating on documentation Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Update docs for subscriptions Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix create_worker bug Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Add more documentation for Worker Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix all todos that can be addressed for now Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Add introductory documentation and a parameter demo Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Add documentation for parameters Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix formatting Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Remove residual directory Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Port over packaging fix Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix formatting for examples Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix distro divergence in guid type Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Fix compilation bug in 1.75 Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> * Force backtrace version that is compatible with 1.75 Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai> --------- Signed-off-by: Michael X. Grey <greyxmike@gmail.com> Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
* upgrade colcon-cargo in pixi.toml * move zip file unzipd own and remove --pypi for upgrade * update name package logging demo * update package name worker demo * update parameter_demo naming
Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
This was referenced Aug 11, 2025
esteve
force-pushed
the
add-examples
branch
3 times, most recently
from
691a229 to
c3d190d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not meant to be merged as is once it's reviewed, because GitHub will mangle the history (see ros2-rust/rosidl_runtime_rs#2 (comment)).
If this PR is approved, I'll just force-push to
mainlocally.Marked this PR as draft to avoid getting merged.