Skip to content
This repository was archived by the owner on Aug 3, 2020. It is now read-only.

update for using multiple visual for collada_urdf#20

Merged
isucan merged 1 commit intoros:groovy-develfrom
YoheiKakiuchi:groovy-devel
Jun 7, 2013
Merged

update for using multiple visual for collada_urdf#20
isucan merged 1 commit intoros:groovy-develfrom
YoheiKakiuchi:groovy-devel

Conversation

@YoheiKakiuchi
Copy link
Contributor

I added code for using multiple visual for converting urdf to collada.
If urdf link has just one visual, there is no difference with former result.
urdf link has more than two visual, first visual would be added with former manner.
Next visuals would be added as transformed geometry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some error messages. They were not needed. Please remove lines start with std::cerr .

@isucan
Copy link
Contributor

isucan commented Jun 3, 2013

This is great, thank you. Do you just take the "default" group and ignore the rest?

Can we do the same for the collision tags?

@YoheiKakiuchi
Copy link
Contributor Author

Do you just take the "default" group and ignore the rest?

Yes. I don't know exact usage visual(collision) group. It seems to have detailed visual(collision) and simple one, and will change depend on situation. I have no idea to do that in collada format.

Can we do the same for the collision tags?

Yes. Now exported collada file has just visual description (same as collision), so we should choose visual tag or collision tag for exporting.

@isucan
Copy link
Contributor

isucan commented Jun 4, 2013

Is it not possible to export both collision and visual in collada? (I am not too familiar with the collada format either). How does one choose visual / collision tags now?

@YoheiKakiuchi
Copy link
Contributor Author

Now in urdf_to_collada, if visual tag exists, visual tag is used as geometry(collision/visual) in collada, and ignore collision tag.
If visual tag does not exist, collision tag is used. If both visual and collision doesn't exist, there is nothing to do (link has no visual/collision).

Collision geometries extension is described at http://openrave.org/docs/latest_stable/collada_robot_extensions/
Now, urdf_to_collada doesn't support this extension. I think it is future work.

isucan added a commit that referenced this pull request Jun 7, 2013
update for using multiple visual for collada_urdf
@isucan isucan merged commit 2eaf5c9 into ros:groovy-devel Jun 7, 2013
YoheiKakiuchi added a commit to jsk-ros-pkg/jsk_3rdparty that referenced this pull request Jun 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants