-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dunfell][gatesgarth][hardknott][honister] Convert to new override syntax #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the result of automated script (0.9.1) conversion: oe-core/scripts/contrib/convert-overrides.py . converting the metadata to use ":" as the override character instead of "_".
_mips wasn't an override in this case Signed-off-by: Martin Jansa <martin.jansa@lge.com>
…ide ROS_BPN _arm wasn't an override in these case Signed-off-by: Martin Jansa <martin.jansa@lge.com>
Merged to other branches as well: |
shr-project
added a commit
to shr-project/superflore
that referenced
this pull request
Aug 16, 2021
* generate new syntax for OE recipes to match: https://lists.openembedded.org/g/openembedded-architecture/message/1260 https://lists.openembedded.org/g/openembedded-architecture/message/1279 https://lists.openembedded.org/g/openembedded-architecture/message/1291 * this was already done with conversion script in meta-ros with: ros/meta-ros#902 but for new ROS Distribution releases we want to generate new syntax directly with superflore. * it's not conditional based on OE release series, because all currently supported versions (dunfell, hardknott, honister) do support new syntax (when latest bitbake revision from corresponding branch is being used). * fixes ros-infrastructure#284 Signed-off-by: Martin Jansa <martin.jansa@lge.com>
shr-project
added a commit
to shr-project/superflore
that referenced
this pull request
Dec 1, 2021
* generate new syntax for OE recipes to match: https://lists.openembedded.org/g/openembedded-architecture/message/1260 https://lists.openembedded.org/g/openembedded-architecture/message/1279 https://lists.openembedded.org/g/openembedded-architecture/message/1291 * this was already done with conversion script in meta-ros with: ros/meta-ros#902 but for new ROS Distribution releases we want to generate new syntax directly with superflore. * it's not conditional based on OE release series, because all currently supported versions (dunfell, hardknott, honister) do support new syntax (when latest bitbake revision from corresponding branch is being used). * fixes ros-infrastructure#284 Signed-off-by: Martin Jansa <martin.jansa@lge.com>
This was referenced Dec 2, 2021
herb-kuta-lge
pushed a commit
to ros-infrastructure/superflore
that referenced
this pull request
Feb 3, 2022
* generate new syntax for OE recipes to match: https://lists.openembedded.org/g/openembedded-architecture/message/1260 https://lists.openembedded.org/g/openembedded-architecture/message/1279 https://lists.openembedded.org/g/openembedded-architecture/message/1291 * this was already done with conversion script in meta-ros with: ros/meta-ros#902 but for new ROS Distribution releases we want to generate new syntax directly with superflore. * it's not conditional based on OE release series, because all currently supported versions (dunfell, hardknott, honister) do support new syntax (when latest bitbake revision from corresponding branch is being used). * fixes #284 Signed-off-by: Martin Jansa <martin.jansa@lge.com>
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
* generate new syntax for OE recipes to match: https://lists.openembedded.org/g/openembedded-architecture/message/1260 https://lists.openembedded.org/g/openembedded-architecture/message/1279 https://lists.openembedded.org/g/openembedded-architecture/message/1291 * this was already done with conversion script in meta-ros with: ros/meta-ros#902 but for new ROS Distribution releases we want to generate new syntax directly with superflore. * it's not conditional based on OE release series, because all currently supported versions (dunfell, hardknott, honister) do support new syntax (when latest bitbake revision from corresponding branch is being used). * fixes ros-infrastructure#284 Signed-off-by: Martin Jansa <martin.jansa@lge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate new syntax for OE recipes to match:
https://lists.openembedded.org/g/openembedded-architecture/message/1260
https://lists.openembedded.org/g/openembedded-architecture/message/1279
https://lists.openembedded.org/g/openembedded-architecture/message/1291
this was done with conversion script in meta-ros, but there is corresponding PR for superflore:
bitbake: generate new overrides syntax ros-infrastructure/superflore#287
to generate new syntax directly for new ROS Distribution releases
it's not conditional based on OE release series, because all
currently supported versions (dunfell, hardknott, honister)
do support new syntax (when latest bitbake revision from
corresponding branch is being used).
if it's still not clear, then bitbake is accepting ':' in
** dunfell with 1.46:
https://git.openembedded.org/bitbake/commit/?h=1.46&id=a6d5fb7554e3cf071e453db56a1e7469ac44277c
https://git.openembedded.org/bitbake/commit/?h=1.46&id=c5418eae56cc50dbae7951c055434a0c456c53a4
** gatesgarth with 1.48:
https://git.openembedded.org/bitbake/commit/?h=1.48&id=aa9f7b80cfdb1119050af469a07ebd949829026c
https://git.openembedded.org/bitbake/commit/?h=1.48&id=14ae61205111383d5f609519c02476925184f6d1
** hardknott with 1.50:
https://git.openembedded.org/bitbake/commit/?h=1.50&id=f8d1bc200460fc1cb5cbf7a7d1986fd86424b22d
https://git.openembedded.org/bitbake/commit/?h=1.50&id=9b2d96b27f550da0fa68ba9ea96be98eb3a832a6
** honister with 1.51+:
https://git.openembedded.org/bitbake/commit/?id=0dbbb4547cb2570d2ce607e9a53459df3c0ac284
https://git.openembedded.org/bitbake/commit/?id=019251649a38754d5877759d13b664e28dea77de
and required since:
https://git.openembedded.org/bitbake/commit/?id=7dcf317cc141dc980634f8c18bfa84f83e57206a
Similarly for poky users (which get bitbake updates together with oe-core updates in combo-layer managed poky repo):
** dunfell:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=dunfell&id=1f7b04355c032cd0de4cbe9352745920964c8057
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=dunfell&id=9c2186108e2e8fcf5837c0ffe9dbdeeaea4b7398
** gatesgarth:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=gatesgarth&id=f2d2136dbb3730abb87699ce03dd54c27ebb7833
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=gatesgarth&id=779ca22928bce94849e32c1bdd5f5d0f64658c2d
** hardknott:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=hardknott&id=666d3421389cc3c01c56e92199cc32bddf1922de
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=hardknott&id=14c5392fded42f17962e1cc07fcc0446881b4fa0
** honister:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=75fad23fc06c008a03414a1fc288a8614c6af9ca
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=d41af446febd516f14f26db53e6572d9eae35b1e
and required since:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=2abf8a699edd513405befbd1a0eafc8f55d6b514
If your builds don't accept new syntax, then you just need to update bitbake a bit.
meta-ros build branch already has necessary bitbake changes since:
[build] Update to latest revisions of upstream layers #894
d3d4a7f
1b876bb
8e9f354
004d801
and honister builds require the new syntax since build branch update in:
[build] Update to latest revisions of upstream layers with new overrides syntax #900
906148d