Skip to content

Update to C++17 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2023
Merged

Update to C++17 #209

merged 1 commit into from
Nov 21, 2023
+3 −2

Conversation

@clalancette
Copy link
Contributor

@clalancette clalancette commented Nov 20, 2023

No description provided.

@clalancette
Update to C++17
a1316b4 
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from gbiggs as a code owner November 20, 2023 15:25
@clalancette
Copy link
Contributor Author

clalancette commented Nov 20, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

ahcorde
ahcorde approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@clalancette
Copy link
Contributor Author

clalancette commented Nov 21, 2023

The Windows failure is a known flake, so going ahead and merging this one.

@clalancette clalancette merged commit baab370 into rolling Nov 21, 2023
@clalancette clalancette deleted the clalancette/update-to-c++17 branch November 21, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clalancette @ahcorde