Add native support to fish shell #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbiggs
reviewed
Mar 1, 2022
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
FelipeGdM
force-pushed
the
feature/fish_support
branch
from
3f82a63 to
4b5cc68
Compare
FelipeGdM
added a commit
to FelipeGdM/ros
that referenced
this pull request
Mar 2, 2022
When ROS added support to fish, the recommended procedure was using source.bash and then manually source rosfish. In this flow, rosbash.fish env hook was never called. To add native support to fish (see ros/catkin#1168), it is needed to ensure consistency along files (scripts ended w/ .fish should be compatible w/ fish)
|
@gbiggs I applied the suggested changes and added some fixes for problems that appeared upon further testing One important addition was the backwards compatibility check to handle In this effort, PR ros/ros#301 was created in order to assert consistency among ROS files |
gbiggs
approved these changes
Mar 24, 2022
paulbovbel
added a commit
to locusrobotics/catkin
that referenced
this pull request
Sep 18, 2023
This reverts commit be490b2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fish shell is an alternative shell to bash or zsh. It defines itself as a
Fish is already kind of supported by catkin with use of the helper bass, as documented in rosbash ROS wiki page. Specific support for it was already discussed in #921
This PR creates the files
setup.fish.inandlocal_setup.fish.into provide native setup scripts for fish users. The main benefit from this update is the possibility to use fish scripts as environment hooks in catkin workspaces.For example, the script rosfish (actual template here) is declared as env hook in the package rosbash
Since
bass source setup.bashruns a bash-like setup, this fish env hook is not loaded, so the usual sequence of commands to start a fish workspace is (as shown in rosbash docs)With this PR, it becomes a simple
With the bonus that not only
rosfishis loaded, but also any other fish-specific env hook in the workspace. It is particularly useful to extend packages like ROS Workspace Scripts to fish environments