Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while building octomap #826

Closed
jbrookshire opened this issue Sep 25, 2016 · 5 comments
Closed

Error while building octomap #826

jbrookshire opened this issue Sep 25, 2016 · 5 comments
Labels

Comments

@jbrookshire
Copy link

jbrookshire commented Sep 25, 2016

Related to: http://answers.ros.org/question/244214/unable-to-install-because-of-missing-ninja/

Solution:

--- catkin/python/catkin/builder.py.orig    2016-09-24 23:22:12.768371606 -0400
+++ catkin/python/catkin/builder.py 2016-09-24 23:22:20.812554961 -0400
@@ -527,11 +527,11 @@
         run_command_colorized(
             make_check_cmake_cmd, build_dir, quiet
         )

     # Run make
-    if not use_ninja:
+    if use_ninja:
         make_executable = 'ninja'
     elif use_nmake:
         make_executable = 'nmake'
     else:
         make_executable = 'make'
@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented Sep 25, 2016

This was introduced in #816. I commented there as well.

@gavanderhoorn
Copy link
Contributor

@jbrookshire: a PR would resolve this sooner I think.

@gavanderhoorn
Copy link
Contributor

What is a bit of a mystery is why the user reporting this in the ROS Answers question only runs into this with OpenCV3.

@jbrookshire
Copy link
Author

Yes, I had the error with all plain cmake packages (for me: octomap, opencv, and orocos)

@dirk-thomas
Copy link
Member

This is clearly a bug in the patch adding Ninja support. Thank you for reporting this. I created #827 to fix the logic and will do a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants