-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer system packages over pip packages for Linux #593
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 93.18% 92.47% -0.71%
==========================================
Files 8 8
Lines 176 186 +10
Branches 17 22 +5
==========================================
+ Hits 164 172 +8
- Misses 12 14 +2
☔ View full report in Codecov by Sentry. |
I'll bump the minor version when releasing this, but it probably needs to be tested manually with real repos first. |
11e495a
to
7375614
Compare
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
7375614
to
d47b718
Compare
Seems to work fine. In the above PR, I removed the workaround (using pip to pin mypy to the version available from apt) and there are no mypy test failures, as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No longer necessary after ros-tooling/setup-ros#593 Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Closes #535
This updates the list of installed packages on Linux to match the installation instructions, which are all pretty much the same for Humble, Iron, and Rolling, which are all currently on Ubuntu 22.04:
Note that we used to install a lot of packages using
pip
. Some of those are included inros-dev-tools
withapt
, and others were simply changed to be installed withapt
instead ofpip
(likepython3-colcon-*
), but some were left out. While we could keep some of them, we can also just letrosdep
install them if they're really needed (byaction-ros-ci
).Everything stays the same for non-Linux platforms and Focal/non-Jammy.
Finally, I did some cleanup and removed old workarounds/comments that don't really apply anymore.
Once this is merged, I'll bump the minor version (
v0.6
->v0.7
).