Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node.js v16 #778

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Upgrade to Node.js v16 #778

merged 4 commits into from
Feb 15, 2023

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Oct 19, 2022 •
edited
Loading

Relates to ros-tooling/setup-ros#519

Requires ros-tooling/setup-ros#521

Closes #780

This also bumps versions of all dependencies. I had to work around a user permission/ID issue, see ros-tooling/setup-ros#521 (comment)

Signed-off-by: Christophe Bedard christophe.bedard@apex.ai

@christophebedard christophebedard requested review from MichaelOrlov and removed request for a team October 19, 2022 00:56
@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 49.44% // Head: 48.73% // Decreases project coverage by -0.72% ⚠️

Coverage data is based on head (45b7c1f) compared to base (27e0fd6).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 45b7c1f differs from pull request most recent head 519def3. Consider uploading reports for the commit 519def3 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   49.44%   48.73%   -0.72%     
==========================================
  Files           2        2              
  Lines         271      277       +6     
  Branches       72       76       +4     
==========================================
+ Hits          134      135       +1     
- Misses        137      142       +5
Impacted Files Coverage Δ
src/action-ros-ci.ts 42.74% <0.00%> (-0.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christophebedard christophebedard mentioned this pull request Oct 19, 2022
Closed
@MichaelOrlov
Copy link
Member

@christophebedard A multiple CI jobs failing.
Does this PR still WIP?

@christophebedard
Copy link
Member Author

@christophebedard A multiple CI jobs failing.

Does this PR still WIP?

Yes, sorry! I expected it to work, but it doesn't work and I haven't had time to properly look into it yet.

@christophebedard christophebedard marked this pull request as draft October 24, 2022 04:43
emersonknapp
emersonknapp approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically fine if everything works fine. Signing off for now to remove from my queue - feel free to re-request review when there are updates.

@christophebedard christophebedard force-pushed the christophebedard/upgrade-to-node-16 branch 4 times, most recently from faf995b to 53af430 Compare February 1, 2023 18:08
@christophebedard
Upgrade to Node.js v16
7fd4b3b 
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/upgrade-to-node-16 branch 3 times, most recently from c3a25d3 to 92f29b8 Compare February 12, 2023 18:13
@christophebedard
Bump versions of all dependencies
f22253b 
Except for @types/node @ 16.

Versions bumped using ncu, see: https://stackoverflow.com/a/22849716.

Update code following Typescript version bump,
see: https://stackoverflow.com/a/69028217.

Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard
Work around 'npm run ...' executing as different user
5f90412 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard force-pushed the christophebedard/upgrade-to-node-16 branch from 92f29b8 to b64d0c4 Compare February 12, 2023 18:15
@christophebedard christophebedard self-assigned this Feb 12, 2023
@christophebedard
Copy link
Member Author

The macOS failures are not related to this PR.

@christophebedard christophebedard mentioned this pull request Feb 12, 2023
Closed
@christophebedard christophebedard marked this pull request as ready for review February 12, 2023 20:53
@christophebedard christophebedard mentioned this pull request Feb 13, 2023
Merged
emersonknapp
emersonknapp approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@christophebedard christophebedard force-pushed the christophebedard/upgrade-to-node-16 branch 2 times, most recently from 95dfd22 to c2d2e35 Compare February 14, 2023 21:28
@christophebedard christophebedard force-pushed the christophebedard/upgrade-to-node-16 branch from c2d2e35 to 465f8e5 Compare February 14, 2023 21:48
@christophebedard
Copy link
Member Author

Argh, I think I force-pushed and overwrote what I had pushed from my personal computer. I'll just wait until I get home and recover the branch.

@christophebedard christophebedard marked this pull request as draft February 14, 2023 21:58
@christophebedard
Use setup-ros@master in CI
519def3 
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
@christophebedard christophebedard force-pushed the christophebedard/upgrade-to-node-16 branch from 465f8e5 to 519def3 Compare February 15, 2023 02:51
@christophebedard christophebedard marked this pull request as ready for review February 15, 2023 02:52
@christophebedard christophebedard enabled auto-merge (squash) February 15, 2023 02:55
@christophebedard christophebedard merged commit e9721b4 into master Feb 15, 2023
@christophebedard christophebedard deleted the christophebedard/upgrade-to-node-16 branch February 15, 2023 05:09
@christophebedard christophebedard mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros-tooling/reviewers

Assignees

@christophebedard christophebedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning: The set-output command is deprecated and will be disabled soon.
3 participants
@christophebedard @MichaelOrlov @emersonknapp