Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifying 2D and 3D messages #2

Merged
merged 5 commits into from
May 23, 2017
Merged

unifying 2D and 3D messages #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12f0451
unified BoundingBox3D and BoundingBox2D msgs
May 22, 2017
c3cdee6
unified ObjectHypothesis 2D and 3D in ObjectHypothesisWithPose
May 22, 2017
3f12c1d
Revert "unified BoundingBox3D and BoundingBox2D msgs"
May 23, 2017
2a8bd77
better description and attempt in normalizing fields
May 23, 2017
3e13194
changed DetectionXD.msg to use generic ObjectHypothesisWithPose
May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,15 @@ find_package(catkin REQUIRED COMPONENTS
add_message_files(
FILES
ObjectHypothesis.msg
ObjectHypothesis2D.msg
ObjectHypothesis3D.msg
ObjectHypothesisWithPose.msg
ClassifierInfo.msg
Classification2D.msg
Classification3D.msg
Detection2D.msg
Detection2DArray.msg
Detection3D.msg
Detection3DArray.msg

BoundingBox2D.msg
BoundingBox3D.msg
BoundingBox.msg
)

## Generate services in the 'srv' folder
Expand Down
4 changes: 2 additions & 2 deletions msg/BoundingBox3D.msg → msg/BoundingBox.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Note: This message plans to move to geometry_msgs in the final implementation.

# position and rotation of the bounding box
# position and orientation of the bounding box center
geometry_msgs/Pose pose
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this PR but related to the other comment. This should probably be more considered an 'origin' or something instead of echoing the datatype.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved the description.


# size of the bounding box
geometry_msgs/Vector3 size
geometry_msgs/Point size
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this to a Point?

This should be documented how to resolve this. What is it relative to? The pose of the pose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted to the original Vector type, and added a better description.

9 changes: 0 additions & 9 deletions msg/BoundingBox2D.msg
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions msg/ObjectHypothesis2D.msg
View file
Open in desktop

This file was deleted.

0 msg/ObjectHypothesis3D.msg → msg/ObjectHypothesisWithPose.msg
View file
Open in desktop
File renamed without changes.