Make NavigateThroughPoses navigator report waypoint statuses information. #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zz990099 <771647586@qq.com>
7 tasks
SteveMacenski
requested changes
Apr 8, 2025
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Please also add in a detailed entry into the migration docs: https://docs.nav2.org/migration/Jazzy.html. It would be good to have documented clearly:
- What is this
- How do I configure it
- How is it managed (which BT nodes; custom nodes)
- That it is populating the feedback/result messages for Navthroughposes/WPF
Signed-off-by: zz990099 <771647586@qq.com>
Signed-off-by: zz990099 <771647586@qq.com>
SteveMacenski
approved these changes
Apr 9, 2025
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Member
|
I had some nitpicks, but nothing I was going to make you deal with. I just committed them inline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros-navigation/navigation2#4994
I’ve updated the port descriptions for
RemovePassedGoalsandRemoveInCollisionGoals, along with the parameter documentation underBtNavigator.