Fix path-to-URL conversion on Python 3.14+ #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottsay
requested review from
claraberendsen and
leander-dsouza
as code owners
cottsay
force-pushed
the
cottsay/temp-url
branch
from
fa7e708 to
1d44bd3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 26.98% 26.98%
=======================================
Files 31 31
Lines 2238 2238
Branches 392 392
=======================================
Hits 604 604
Misses 1574 1574
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leander-dsouza
requested changes
Nov 4, 2025
Member
|
Thank you for pointing out the issue with file paths. I guess we need to add Python 3.14 to the workflow in the near future to catch impending errors. |
Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
cottsay/temp-url
branch
from
1d44bd3 to
b1f0a25
Compare
leander-dsouza
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
I don't really understand why this was working correctly before, but changes to
pathname2urlin Python 3.14 are causing the resulting URL to have only a single leading slash, e.x.file:/foo/bar.Found while packaging
vcs2lfor Fedora Rawhide.Description of how this change was tested
pre-commit run --allpython3 -m pytest -s -v test