Enable test run on mercurial and subversion #42
Conversation
leander-dsouza
force-pushed
the
leander-dsouza/fix-svn-test
branch
from
1ce645f to
659c3b8
Compare
leander-dsouza
force-pushed
the
leander-dsouza/fix-svn-test
branch
from
659c3b8 to
5f6ce04
Compare
test/test_commands.py
Outdated
There was a problem hiding this comment.
This should be ok to drop since the only usage here is to skip the hg and svn test from running on CI environments.
There was a problem hiding this comment.
I feel there is some merit in having the Mercurial and Subversion tests run on the CI.
This is also because the Vcstools PR #43 contains additional tests for hg and svn to be run in CI for validation.
test/list2.repos
Outdated
There was a problem hiding this comment.
Shouldn't the url here be https://svn.apache.org/repos/asf/subversion/ ?
There was a problem hiding this comment.
Yes, you are correct, Clara.
The validation would be more accurate if it targeted a specific repository instead of a blanket of them.
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
leander-dsouza
force-pushed
the
leander-dsouza/fix-svn-test
branch
from
5f6ce04 to
e47aac4
Compare
| url: https://github.com/ros-infrastructure/vcs2l | ||
| version: 3 | ||
| url: https://svn.apache.org/repos/asf/subversion | ||
| version: 1928014 |
There was a problem hiding this comment.
For better understanding here could you explain were you are fetching this version number from?
There was a problem hiding this comment.
The subversion repository link has the version mentioned as the revision tag.
Basic Info
Description of contribution in a few bullet points
Description of how this change was tested
Ran
pytestlocally to ensure all the unit and linting tests pass:pytest -s -v testSigned-off-by: Leander Stephen Desouza leanderdsouza1234@gmail.com