yocto_recipe.py: Fix setting sensible default for <build_type> when n…

…ot ROS 1 (#267)

* get_ros_version expects just a string (as in distro.name) not whole RosDistro class
  This is a bit confusing, because in many places we use the same distro variable
  as this string, rename it to make it more clear in the next commit.

superflore/generators/bitbake/yocto_recipe.py

@@ -97,7 +97,8 @@ def __init__(
             self.license = None
             self.homepage = None
             self.build_type = 'catkin' if \
-                yoctoRecipe._get_ros_version(distro) == 1 else 'ament_cmake'
+                yoctoRecipe._get_ros_version(distro.name) == 1 \
+                else 'ament_cmake'
             self.maintainer = "OSRF"
         self.depends = set()
         self.depends_external = set()