Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow SYS_PTRACE capability when running tests #832

Closed
wants to merge 1 commit into from

Conversation

@dirk-thomas dirk-thomas self-assigned this Aug 24, 2020
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ptrace capability is an especially egregious one when it comes to capabilities for containers running untrusted code (as devel and CI jobs do) since escaping the container with the ptrace capability gives you lots of potential for damage (https://nvd.nist.gov/vuln/detail/2016-9962 is an example from memory where ptrace makes it easier to leverage a container escape). I am very hesitant to add this capability and would want to see a discussion of the added risk and the mitigations in place for it.

@dirk-thomas
Copy link
Member Author

dirk-thomas commented Aug 25, 2020

I am very hesitant to add this capability and would want to see a discussion of the added risk and the mitigations in place for it.

Please start the discussion somewhere - not sure what the best place for it would be - here or Slack?

Do you have an alternative proposal how to address the failing test?

Since this currently makes several jobs unstable I would like to get them green within a few days. If the discussion needs more time and there is no alternative I probably woulddisable the sanitizer for now.

@dirk-thomas
Copy link
Member Author

Closing since undesired.

Instead the sanitizer is being disabled in the rosbag2_cpp package: ros2/rosbag2#517.

@dirk-thomas dirk-thomas deleted the dirk-thomas/add-ptrace-cap branch August 25, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants