Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in RHEL 8 / Python3.6 support. #700

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Apr 6, 2023

Addresses #683 (comment)

@ijnek ijnek changed the title Check for python version to handle method signature change in argparse Fix change that broke bloom in RHEL 8 Python3.6 - argparse Apr 6, 2023
@ijnek ijnek changed the title Fix change that broke bloom in RHEL 8 Python3.6 - argparse Fix change that broke bloom in RHEL 8 / Python3.6 - argparse Apr 6, 2023
@ijnek
Copy link
Member Author

ijnek commented Apr 9, 2023

Don't know why CI didn't run on ubuntu-18.04 runners.

@cottsay
Copy link
Member

cottsay commented Apr 9, 2023

Don't know why CI didn't run on ubuntu-18.04 runners.

They're doing brownouts on 18.04 to spread awareness of the impending EOL. I re-triggered them.

@nuclearsandwich nuclearsandwich mentioned this pull request Mar 29, 2024
ijnek and others added 3 commits March 29, 2024 15:01
Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
@nuclearsandwich
Copy link
Contributor

I've rebased these changes in order to get fresh (hopefully working) CI.

@nuclearsandwich nuclearsandwich changed the title Fix change that broke bloom in RHEL 8 / Python3.6 - argparse Fixr regression in RHEL 8 / Python3.6 support. Mar 29, 2024
@nuclearsandwich nuclearsandwich changed the title Fixr regression in RHEL 8 / Python3.6 support. Fix regression in RHEL 8 / Python3.6 support. Mar 29, 2024
@cottsay cottsay merged commit b3e1b3a into ros-infrastructure:master Mar 29, 2024
15 checks passed
@ijnek ijnek deleted the ijnek-check-python-37 branch April 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants