-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression in RHEL 8 / Python3.6 support. #700
Merged
cottsay
merged 3 commits into
ros-infrastructure:master
from
ijnek:ijnek-check-python-37
Mar 29, 2024
Merged
Fix regression in RHEL 8 / Python3.6 support. #700
cottsay
merged 3 commits into
ros-infrastructure:master
from
ijnek:ijnek-check-python-37
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijnek
changed the title
Check for python version to handle method signature change in argparse
Fix change that broke bloom in RHEL 8 Python3.6 - argparse
Apr 6, 2023
ijnek
changed the title
Fix change that broke bloom in RHEL 8 Python3.6 - argparse
Fix change that broke bloom in RHEL 8 / Python3.6 - argparse
Apr 6, 2023
Don't know why CI didn't run on ubuntu-18.04 runners. |
They're doing brownouts on 18.04 to spread awareness of the impending EOL. I re-triggered them. |
Merged
Signed-off-by: ijnek <kenjibrameld@gmail.com>
Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
nuclearsandwich
force-pushed
the
ijnek-check-python-37
branch
from
March 29, 2024 22:01
5216256
to
6daa1d5
Compare
I've rebased these changes in order to get fresh (hopefully working) CI. |
nuclearsandwich
approved these changes
Mar 29, 2024
nuclearsandwich
changed the title
Fix change that broke bloom in RHEL 8 / Python3.6 - argparse
Fixr regression in RHEL 8 / Python3.6 support.
Mar 29, 2024
nuclearsandwich
changed the title
Fixr regression in RHEL 8 / Python3.6 support.
Fix regression in RHEL 8 / Python3.6 support.
Mar 29, 2024
cottsay
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #683 (comment)