Create and use a 'fake' rosdep cache for tests #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottsay
force-pushed
the
cottsay/fake_rosdep
branch
from
d6b91f2 to
a0dc05c
Compare
The idea here is to decouple Bloom from the live rosdistro index and rosdep database. This will also isolate bloom from the rosdep state that the system has, and makes the tests function without any network access. Since the system rosdep state isn't a dependency any more, the tests can be run even if 'rosdep init' has not been invoked on the system, meaning that the tests can now be executed without sudo rights. This change also significantly reduces the time it takes to run the tests. Part of that is due to the 'BLOOM_SKIP_ROSDEP_UPDATE', which suppresses Bloom's automatic rosdep update invocation. This isn't necessary for the 'fake' rosdep cache to work, but it makes things a bit quicker.
The tests are no longer dependent on the system's rosdep state.
cottsay
force-pushed
the
cottsay/fake_rosdep
branch
from
a0dc05c to
948fc53
Compare
|
This brought the Travis build down from ~20 min to ~8 min. I expect there will be similar gains in GitHub Actions. |
tfoote
approved these changes
Jan 23, 2021
nuclearsandwich
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to decouple Bloom from the live rosdistro index and rosdep database. This will also isolate bloom from the rosdep state that the system has, and makes the tests function without any network access. Since the system rosdep state isn't a dependency any more, the tests can be run even if 'rosdep init' has not been invoked on the system, meaning that the tests can now be executed without sudo rights.
This change also significantly reduces the time it takes to run the tests. Part of that is due to the
BLOOM_SKIP_ROSDEP_UPDATEvalue, which suppresses Bloom's automatic rosdep update invocation. This isn't necessary for the 'fake' rosdep cache to work, but it makes things a bit quicker.This change is motivated by the tests currently failing due to ros/rosdistro#27640. Rather than just update the tests to reflect the change, this approach will isolate the tests from future changes of the same kind.
Closes #616