Add a template substitution for the ROS distro #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most common patching error I've seen in Bloom repositories manifests from carrying forward a patch from a previous track to a new one, when that patch has a hard-coded ROS distribution name in it. Unfortunately, this error often goes unnoticed when the patch modifies the weak dependencies of a package. This substitution will allow us to roll the patches forward unmodified.
nuclearsandwich
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
This is a use case we've talked about and wanted for a while now and I'm happy to see it being enabled.
I have a comment about the casing convention where I've proposed a few alternatives of which I already approve. If there's a further alternative or a reason to stick with the patch as-is I'll gladly re-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most common patching error I've seen in Bloom repositories manifests from carrying forward a patch from a previous track to a new one, when that patch has a hard-coded ROS distribution name in it. Unfortunately, this error often goes unnoticed when the patch modifies the weak dependencies of a package.
This substitution will allow us to roll the patches forward unmodified.