Add RHEL to the default action list #604
Conversation
The default distribution for the RPM generator is Fedora. Since we're going to start generating RPMs for RHEL/CentOS, we need to update the template to perform generation for that platform specifically.
I think that every package will get a new prompt about how their action list is different from the default, and ask if the action list should be updated to the default. This will be true of ALL packages using bloom, not just ROS 2. |
|
Oh yeah, I forgot about that feature 🙃. |
I wish there was a gentler way to do this, but the only alternative I see would be to change the default for the RPM generator from Fedora to RHEL. With buildfarm support for RPMs basically done, it isn't unreasonable to think that we could target Fedora in the future, so I don't think that's a good route. A fair number of packages will get the updated template as I bloom them for Eloquent, so I can just update the other tracks while I'm at it. There isn't much I can do about community-maintained packages, though. |
|
We don't have a bloom track for ROS discourse but it might be worth announcing this change in the general Packaging and Release Management category. |
| ' :{ros_distro} -i :{release_inc} --os-name fedora', | ||
| 'git-bloom-generate -y rosrpm --prefix release/:{ros_distro}' | ||
| ' :{ros_distro} -i :{release_inc} --os-name rhel', |
There was a problem hiding this comment.
@cottsay have you considered whether we should use the --os-not-required option in the default actions for fedora or rhel as we do for debian above?
There was a problem hiding this comment.
That option is only for the Debian generator: https://github.com/ros-infrastructure/bloom/search?q=os_not_required
The RPM generator always acts as if --os-not-required was specified.
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/rhel-coming-to-bloom-action-template/16582/1 |
The default distribution for the RPM generator is Fedora. Since we're going to start generating RPMs for RHEL/CentOS, we need to update the template to perform generation for that platform specifically.