Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt if --override-release-repository-url #594

Merged

Conversation

icolwell-as
Copy link
Contributor

Resolves #593

Please review closely as this is my first time looking at bloom source and wasn't sure how to run/test it from the source.

@nuclearsandwich
Copy link
Contributor

Please review closely as this is my first time looking at bloom source and wasn't sure how to run/test it from the source.

Thanks for taking the time to contribute a fix for your issue!

I test bloom locally by setting up a python virtualenv and running python setup.py develop while that virtualenv is active.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it's working great for me. Thanks for the improvement!

@nuclearsandwich nuclearsandwich merged commit c4fa834 into ros-infrastructure:master Nov 13, 2020
@icolwell-as
Copy link
Contributor Author

Thanks for testing!

@icolwell-as icolwell-as deleted the override_url_no_prompt branch November 13, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bloom prompts for release repository url even when "--override-release-repository-url" provided
2 participants