Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for BLOOM_NO_ROSDISTRO_PULL_REQUEST environment variable #548

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 9, 2019

The goal of the variable is to avoid the steps of generating and pushing the PR with changes to rosdistro.

Not usual for catkin packages but we have use cases where we use bloom to generate the metadata and use build.osrfoundation.org to build packages that can not go into rosdistro index.

j-rivero and others added 2 commits September 9, 2019 16:17
The variable is designed to avoid the steps of generating and pushing
the PR with changes to rosdistro. This options is unusual in the
normal worklow for ROS packages for those cases where the catkin
package is not part of the official ROS ecosystem and repositories.
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I added a command line flag for the setting as well.

@nuclearsandwich nuclearsandwich merged commit d6a7314 into ros-infrastructure:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants