Always create archive of sources when building RPM #540
Conversation
|
@cottsay it looks like this change still has some CI failures. |
|
Yeah, I'm still working on this one. |
|
Okay, I fixed it. This is now ready for review like the other two RPM PRs. |
|
@cottsay this |
|
That was my logic, yes. |
|
As is this change is going to create a conflict with @lennonwoo's work refactoring the template placement so it isn't platform specific. I'm not sure whether plain overloading or a hook style system is the right way to go but I think both of you are closer to it than I am. |
|
Could we put the logic into generate_rpm function there? |
The SCM plugin for mock will create an archive of the sources if either this marker file is present in the root of the project or the `write_tar` option is specified in mock's configuration. The way bloom works, we always want to archive the sources, but this isn't the default configuration of the SCM plugin. Writing this marker file means one less configuration is necessary when consuming the release repo to build the RPMs with mock.
|
At first glance I didn't think I could use So that simplified the change. Good call, @lennonwoo! |
|
From what I can tell, we'll still have to perform a merge, but I think this will still mesh with the generator refactor. |
|
Year, this and #534 should be merged first, then we can do rebase to the generator refactor. |
…e#540) The SCM plugin for mock will create an archive of the sources if either this marker file is present in the root of the project or the `write_tar` option is specified in mock's configuration. The way bloom works, we always want to archive the sources, but this isn't the default configuration of the SCM plugin. Writing this marker file means one less configuration is necessary when consuming the release repo to build the RPMs with mock. Signed-off-by: Scott K Logan <logans@cottsay.net>
The SCM plugin for mock will create an archive of the sources if either this marker file is present in the root of the project or the
write_taroption is specified in mock's configuration.The way bloom works, we always want to archive the sources, but this isn't the default configuration of the SCM plugin. Writing this marker file means one less configuration is necessary when consuming the
release repo to build the RPMs with mock.
More info: https://fedoraproject.org/wiki/Projects/Mock/Plugin/Scm#Tar_file