Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service to get robot software version. #24

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

URJala
Copy link
Contributor

@URJala URJala commented Feb 15, 2024

No description provided.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level: please provide a description when submitting PRs, and be sure to include a motivation for why this should be merged.

Additionally: the new definitions are missing an empty last line.

CMakeLists.txt Outdated Show resolved Hide resolved
srv/GetVersion.srv Outdated Show resolved Hide resolved
@URJala
Copy link
Contributor Author

URJala commented Feb 15, 2024

Motivation for this PR is to be able to provide the software version of UR robots as a topic. The integration tests in the universal robots ROS driver requires being able to distinguish between different software versions, to know which tests to run. Sorry for the missing description, i am currently working on a PR on the ROS driver which requires the changes in this PR.

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fair, thanks for iterating this @URJala I'll wait with merging this until we've sorted out the controller part, though.

@fmauch fmauch merged commit 243e93a into ros-industrial:melodic-devel Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants