Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param for vel scaling of the scan movement #240

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from

Conversation

Chamango90
Copy link

  • The new parameter uses setMaxVelocityScalingFactor() to set the scaling of the velocity for the movement to/between the scan points.

  • The function is called with the parameter in the RobotScan::init() function. This is actually not required because of the next bullet-point. However, I left it to be consistent with the other params like e.g. move_group_ptr_->setMaxVelocityScalingFactor(params_.move_scan_vel_scaling);

  • I also added this function to the RobotScan::create_scan_trajectory(...) function. So if one changes the parameter in the gui, it is applied for the next scan process. setEndEffectorLink(params_.tcp_frame)

  • Parameter got added in the RobotScanParameters.msg

  • I set the default value and the one in robot_scan.yaml(s) to 1, which applies no scaling

  • Added the parameter to the gui(s)

  • Had to increase the hight of the gui(s) to make space for the new field

image

Copy link
Contributor

@AustinDeric AustinDeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Any objections? If not i am going to merge in 48 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants