Skip to content

Conversation

@ethanholter
Copy link

When using newer gamepads such as the Dualshock 5 it's pretty common to see messages along the lines of Unknown event type 1623. These messages can be useful for maintainers of the joystick_drivers package but the average joe doesn't really care.

In some scenarios, such as with the aforementioned Dualshock 5, these messages will be printed in a torrential flood at whatever rate the joy_node is publishing at. It is quite frustrating to suddenly need to sift through hundreds of lines of repeated log messages simply because I accidentally bumped my controllers touch pad.

This pull request proposes adding a list of SDL events which are explicitly known to pose no function within the joy_node. This way any actually anomalous unknown events can still be logged without the worry of drowning in useless log messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant