surpress warnings for known unused event types #307
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using newer gamepads such as the Dualshock 5 it's pretty common to see messages along the lines of
Unknown event type 1623. These messages can be useful for maintainers of the joystick_drivers package but the average joe doesn't really care.In some scenarios, such as with the aforementioned Dualshock 5, these messages will be printed in a torrential flood at whatever rate the joy_node is publishing at. It is quite frustrating to suddenly need to sift through hundreds of lines of repeated log messages simply because I accidentally bumped my controllers touch pad.
This pull request proposes adding a list of SDL events which are explicitly known to pose no function within the joy_node. This way any actually anomalous unknown events can still be logged without the worry of drowning in useless log messages