fix autorepeat not being triggered when inside deadzone (#261)

when the joystick is moved there is an SDL_Event, but when inside the deadzone the position of the joystick will not be updated. In this case should_publish remains false. However, before this commit we would not trigger the autorepeat functionality in this case.

Now we trigger the autorepeat functionality everytime where we didnt update the joystick (due to deadzone) or when there was no SDL_Event.

joy/src/joy.cpp

@@ -450,8 +450,16 @@ void Joy::eventThread()
       } else {
         RCLCPP_INFO(get_logger(), "Unknown event type %d", e.type);
       }
-    } else {
-      // We didn't succeed, either because of a failure or because of a timeout.
+    }
+
+    if (!should_publish) {
+      // So far, nothing has indicated that we should publish.  However we need to
+      // do additional checking since there are several possible reasons:
+      // 1.  SDL_WaitEventTimeout failed
+      // 2.  SDL_WaitEventTimeout timed out
+      // 3.  SDL_WaitEventTimeout succeeded, but the event that happened didn't cause
+      //     a publish to happen.
+      //
       // If we are autorepeating and enough time has passed, set should_publish.
       rclcpp::Time now = this->now();
       rclcpp::Duration diff_since_last_publish = now - last_publish;