Update ThreadSafeBox Tests #459
Conversation
github-actions
bot
requested review from
VX792,
christophfroehlich,
destogl,
fmauch,
livanov93,
mhubii and
qiayuanl
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 85.25% 85.26% +0.01%
==========================================
Files 17 17
Lines 1397 1398 +1
Branches 132 132
==========================================
+ Hits 1191 1192 +1
Misses 120 120
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks.
On rolling we have a windows workflow in the CI, which fails now
D:\a\realtime_tools\realtime_tools\src\ros-controls\realtime_tools\realtime_tools\include\realtime_tools\mutex.hpp(21,1): error C1189: #error: "The mutex.hpp header is not supported on Windows platforms" [D:\a\realtime_tools\realtime_tools\build\realtime_tools\realtime_thread_safe_box_tests.vcxproj]
Can you please make the list of types depending on the platform?
christophfroehlich
added
backport-jazzy
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
Looks fine to me. Please see my comment as a suggestion, but feel free to ignore it.
| // Priority mutexes are not available on Windows platforms | ||
| #ifdef _WIN32 | ||
| using TestTypes = ::testing::Types<std::mutex>; | ||
| #else | ||
| using TestTypes = ::testing::Types< | ||
| std::mutex, realtime_tools::prio_inherit_mutex, realtime_tools::prio_inherit_recursive_mutex>; | ||
| #endif |
There was a problem hiding this comment.
Could we move that together with the realtime_tools/mutex include?
(cherry picked from commit 534bfab)
(cherry picked from commit 534bfab)
4 participants
Changes
realtime_thread_safe_box_tests(similar test is inhumble)