Add guidelines for realtimebox/queue #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
bmagyar,
destogl,
mhubii,
moriarty,
qiayuanl and
xguay
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 86.92% 86.75% -0.17%
==========================================
Files 17 17
Lines 1262 1261 -1
Branches 102 102
==========================================
- Hits 1097 1094 -3
- Misses 98 99 +1
- Partials 67 68 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor
approved these changes
May 29, 2025
This was referenced May 30, 2025
This was referenced May 31, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
(cherry picked from commit cbf7ae6)
christophfroehlich
added a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #279
I tried to formulate what I understood so far, and would use that guideline to change all ros2_controllers.
Should we now deprecate the RealtimeBuffer?