Fix RealtimeBox broken API + realtime_box_best_effort.h proper deprecation

[saikishor]

Fixes: #200

@christophfroehlich Thanks for nice summary of the issue.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.42%. Comparing base (5db607c) to head (b51bab6).

Files with missing lines	Patch %	Lines
include/realtime_tools/realtime_box.h	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   73.47%   73.42%   -0.05%     
==========================================
  Files           7        7              
  Lines         411      414       +3     
  Branches       67       68       +1     
==========================================
+ Hits          302      304       +2     
  Misses         68       68              
- Partials       41       42       +1     

Flag	Coverage Δ
unittests	73.42% <66.66%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
include/realtime_tools/realtime_box.h	85.24% <66.66%> (-0.97%)	⬇️

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[christophfroehlich]

Thx for the fix.

I can confirm that ros2_controllers builds again now from master. UR driver doesn't but has a useful error message (and my PR fixing it):

/workspaces/ros2_rolling_ws/src/Universal_Robots_ROS2_Driver/ur_controllers/src/ur_configuration_controller.cpp:117:34: error: ‘realtime_tools::RealtimeBoxBestEffort<std::shared_ptr<ur_controllers::VersionInformation> >’ {aka ‘class realtime_tools::RealtimeBoxBase<std::shared_ptr<ur_controllers::VersionInformation>, std::mutex>’} has no member named ‘tryGet’; did you mean ‘try_get’?
  117 |   return robot_software_version_.tryGet([resp](const std::shared_ptr<VersionInformation> ptr) {
      |                                  ^~~~~~
      |                                  try_get

[saikishor]

Thx for the fix.

I can confirm that ros2_controllers builds again now from master. UR driver doesn't but has a useful error message (and my PR fixing it):

/workspaces/ros2_rolling_ws/src/Universal_Robots_ROS2_Driver/ur_controllers/src/ur_configuration_controller.cpp:117:34: error: ‘realtime_tools::RealtimeBoxBestEffort<std::shared_ptr<ur_controllers::VersionInformation> >’ {aka ‘class realtime_tools::RealtimeBoxBase<std::shared_ptr<ur_controllers::VersionInformation>, std::mutex>’} has no member named ‘tryGet’; did you mean ‘try_get’?
  117 |   return robot_software_version_.tryGet([resp](const std::shared_ptr<VersionInformation> ptr) {
      |                                  ^~~~~~
      |                                  try_get

Shit, then we need to add a this method and deprecation note. I'll add it tonight. Sorry about that

[saikishor]

@christophfroehlich I just pushed the deprecated methods as well. Please let me know, if it works now :)

[christophfroehlich]

LGTM, ur_controllers build now fine

[saikishor]

LGTM, ur_controllers build now fine

Thanks a lot for checking. I didn't have time to check it with ur_controllers