Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (7114143) to head (a956c15).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files           7        7           
  Lines         414      414           
  Branches       68       68           
=======================================
  Hits          304      304           
  Misses         68       68           
  Partials       42       42           
Flag Coverage Δ
unittests 73.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I'm loving that! Finally we use that one :-)

@christophfroehlich
Copy link
Contributor Author

what is your opinion: Not testing and just building everything is fine here?

@saikishor
Copy link
Member

what is your opinion: Not testing and just building everything is fine here?

I don't think we have to test anything for now. We just build and that's it and for the testing we have the nightly builds. If we have a use case in future, let's do that

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit b28ce79 into master Nov 25, 2024
23 checks passed
@christophfroehlich christophfroehlich deleted the ci/downstream branch November 25, 2024 15:52
@fmauch
Copy link
Contributor

fmauch commented Nov 25, 2024

what is your opinion: Not testing and just building everything is fine here?

I don't think we have to test anything for now. We just build and that's it and for the testing we have the nightly builds. If we have a use case in future, let's do that

I would agree in that case.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link

mergify bot commented Dec 4, 2024

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
(cherry picked from commit b28ce79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants