-
Notifications
You must be signed in to change notification settings - Fork 89
Add downstream build CI job #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 7 7
Lines 414 414
Branches 68 68
=======================================
Hits 304 304
Misses 68 68
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
fmauch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, I'm loving that! Finally we use that one :-)
|
what is your opinion: Not testing and just building everything is fine here? |
I don't think we have to test anything for now. We just build and that's it and for the testing we have the nightly builds. If we have a use case in future, let's do that |
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would agree in that case. |
|
@Mergifyio backport humble |
✅ Backports have been created
|
(cherry picked from commit b28ce79)
#200